SSLContextCache: use DispatchQueue instead of NIOThreadPool #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
approved these changes
May 13, 2021
fabianfett
reviewed
May 13, 2021
glbrntt
reviewed
May 13, 2021
weissi
force-pushed
the
jw-dq-for-context
branch
2 times, most recently
from
4ac7ef2 to
6db559a
Compare
glbrntt
approved these changes
May 13, 2021
fabianfett
approved these changes
May 13, 2021
Member
fabianfett
left a comment
fabianfett
left a comment
There was a problem hiding this comment.
Yay. Less code to maintain. Thanks! 🥳
Motivation: In the vast majority of cases, we'll only ever create one and only one `NIOSSLContext`. It's therefore wasteful to keep around a whole thread doing nothing just for that. A `DispatchQueue` is absolutely fine here. Modification: Run the `NIOSSLContext` creation on a `DispatchQueue` instead. Result: Fewer threads hanging around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In the vast majority of cases, we'll only ever create one and only one
NIOSSLContext. It's therefore wasteful to keep around a whole threaddoing nothing just for that. A
DispatchQueueis absolutely fine here.Modification:
Run the
NIOSSLContextcreation on aDispatchQueueinstead.Result:
Fewer threads hanging around.